Hello all, I am trying to map a macro for triggering 1Password to the Butterfly key in the QWERTY layout. If you are not familiar with 1Password shortcuts, in applications with native integrations the login box can be brought up with Cmd + \, while a more generic keyboard-emulating box can be broug…

From looking at the source of the macros plugin, I think the issue is happening because it doesn’t mask the held modifiers, so when the macro sends the new keyboard report, it clears the previously-held keys (I think; my understanding of how key presses & reports work is not exactly 100%). The easi…

I’m betting this is (somewhat) dependent on key handling order. I think if you put the modifier (option) on a key that gets handled before the macro key (generally speaking, on a row closer to the top), you’d see the opt getting released after the first keypress event of the macro. It still wouldn’t…

@algernon : How do you feel about held keys (and OneShot modifiers) persisting in the keyboard report while Macros are playing? I think they should, and I’ve got a plan for how to do it, but I don’t want to bother doing the work on that unless you think it’s a good idea. If you do think it’s a good i…

Macros should not be clearing the report, so held keys should persist. What we see here is more likely an ordering issue. Other than that - yes, held keys, OneShots and everything else that was active when the macro triggered, should persist throughout the macro.

Of course! I’m now wondering why I thought the report was cleared. I’ll submit a PR with a fix sometime this week unless you do it first.

I’m working on a PR to fix this problem: https://github.com/keyboardio/Kaleidoscope-Macros/pull/20

Thanks for the help! In the mean time I’ve followed @james.nvc suggestion and augmented my macro to use wasModifierKeyActive, but unfortunately I am getting somewhat funky behavior: case MACRO_1PASSWORD: if (kaleidoscope::hid::wasModifierKeyActive(Key_RightAlt)) { return MACRODOWN(D(Right…

[image] CrzRussian252: Is this another ordering issue and expected behavior? I’m not sure why you’re seeing those keys out of order in this case. If I get some time, I’ll try it out tomorrow myself.

I suspect that your keymap contains a Key_LeftAlt (i.e. left option), but not a Key_RightAlt, which is what you would need for that macro to work the way you want it to. If that’s the case, you can change the test in MACRO_1PASSWORD to check for Key_LeftAlt, and then it should work.

@merlin You are right, the Alt key on the right side of the keyboard is actually a LeftAlt in the map. I corrected the macro and it now works as intended. Thank you so much!

Combining macros with modifiers

Programming

JDH February 21, 2018, 5:42am 13

Here is the thread that mentioned this earlier.

Topic		Replies	Views
Unable to make my macro work with new firmware Programming question , plugin	15	1033	March 2, 2022
Macro or shortcut or ...? Help and Getting Started	5	788	June 19, 2018
Need help making a layer that has a modifier key held down for some keys Programming question	2	368	November 7, 2022
Macro that respects one-shot modifier keys Help and Getting Started	8	510	January 30, 2023
Macros with modifiers Programming	6	1450	January 1, 2018

Combining macros with modifiers

Related topics